|Summary:||QWebPage::findText() does not clear selection when passed empty string|
|Product:||WebKit||Reporter:||Mark Turney <markturney>|
|Component:||WebKit Qt||Assignee:||QtWebKit Unassigned <webkit-qt-unassigned>|
|Severity:||Normal||CC:||adawit, benjamin, commit-queue, hausmann, jesus, kent.hansen, markturney, pierre.rossi, rion4ik, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Mark Turney 2009-11-21 19:51:08 PST
Created attachment 43670 [details] running example of the bug in question The text within the Qt documentation for QWebPage::findText() states that "To clear the selection, just pass an empty string.". When an empty string is passed into this method as demonstrated by the included cpp file, QWebPage::findText() fails to clear the selection. This bug was tested in 4.6-RC1 on Linux64.
Comment 1 Rion 2010-01-13 14:28:41 PST
the same for 4.6.0 release.
Comment 2 Dawit A. 2010-03-03 15:12:52 PST
FYI... Clearing of the selection will work correctly for the text highlighted when the HighlightAllOccurrances flag is set so long as you specify this very same flag when you calling the function with an empty string...
Comment 3 Benjamin Poulain 2010-03-05 15:50:15 PST
Same with trunk.
Comment 5 WebKit Review Bot 2010-06-08 12:52:40 PDT
Attachment 58169 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/qt/ChangeLog:5: Line contains tab character. [whitespace/tab]  WebKit/qt/ChangeLog:6: Line contains tab character. [whitespace/tab]  WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp" WARNING: File exempt from style guide. Skipping: "WebKit/qt/tests/qwebpage/tst_qwebpage.cpp" Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Pierre Rossi 2010-06-08 12:57:51 PDT
Created attachment 58172 [details] Argh, my Changelog really had no style at all!
Comment 7 WebKit Commit Bot 2010-06-09 21:39:50 PDT
Comment on attachment 58172 [details] Argh, my Changelog really had no style at all! Clearing flags on attachment: 58172 Committed r60935: <http://trac.webkit.org/changeset/60935>
Comment 8 WebKit Commit Bot 2010-06-09 21:39:59 PDT
All reviewed patches have been landed. Closing bug.