| Summary: | QWebPage::findText() does not clear selection when passed empty string | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Turney <markturney> | ||||||||
| Component: | WebKit Qt | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||||
| Status: | CLOSED FIXED | ||||||||||
| Severity: | Normal | CC: | adawit, benjamin, commit-queue, hausmann, jesus, kent.hansen, markturney, pierre.rossi, rion4ik, webkit.review.bot | ||||||||
| Priority: | P3 | Keywords: | Qt, QtTriaged | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
the same for 4.6.0 release. FYI... Clearing of the selection will work correctly for the text highlighted when the HighlightAllOccurrances flag is set so long as you specify this very same flag when you calling the function with an empty string... Same with trunk. Created attachment 58169 [details]
proposed patch
Attachment 58169 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/qt/ChangeLog:5: Line contains tab character. [whitespace/tab] [5]
WebKit/qt/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/tests/qwebpage/tst_qwebpage.cpp"
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 58172 [details]
Argh, my Changelog really had no style at all!
Comment on attachment 58172 [details] Argh, my Changelog really had no style at all! Clearing flags on attachment: 58172 Committed r60935: <http://trac.webkit.org/changeset/60935> All reviewed patches have been landed. Closing bug. |
Created attachment 43670 [details] running example of the bug in question The text within the Qt documentation for QWebPage::findText() states that "To clear the selection, just pass an empty string.". When an empty string is passed into this method as demonstrated by the included cpp file, QWebPage::findText() fails to clear the selection. This bug was tested in 4.6-RC1 on Linux64.