Bug 31778

Summary: Chromium: make rounded borders heavier.
Product: WebKit Reporter: Adam Langley <agl>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: brettw, commit-queue, eric, jparent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch none

Adam Langley
Reported 2009-11-21 16:53:33 PST
Skia draws its rounded corners differently from the other ports. Whereas they have anti-aliased clipping regions, Skia only has 1-bit regions. (Which is technically more correct, but somewhat unhelpful for us.) Instead, with Skia we use a layer and collect all the clipping paths in effect. When the state is popped, we paint transparency outside the clipping paths and merge the layer down. This appears to cause rounded borders to look a little thin, which is addressed in this patch. This is well covered by existing tests but will require new baselines in the Chromium tree.
Attachments
patch (2.20 KB, patch)
2009-11-21 16:55 PST, Adam Langley 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-11-21 16:55:52 PST
Created attachment 43668 [details] patch (Note: please don't cq+ this patch.)
Eric Seidel (no email)
Comment 2 2009-11-23 20:09:07 PST
Comment on attachment 43668 [details] patch Marking cq- per Adam's note above.
Eric Seidel (no email)
Comment 3 2009-11-23 20:10:07 PST
Comment on attachment 43668 [details] patch LGTM. CC'd brett so he sees this go by.
Julie Parent
Comment 4 2009-12-04 15:35:12 PST
Comment on attachment 43668 [details] patch Setting commit-queue+ as we are ready on Chromium side for this to land.
WebKit Commit Bot
Comment 5 2009-12-04 16:39:34 PST
Comment on attachment 43668 [details] patch Clearing flags on attachment: 43668 Committed r51722: <http://trac.webkit.org/changeset/51722>
WebKit Commit Bot
Comment 6 2009-12-04 16:39:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.