Summary: | 'bugzilla-tool help' should only show common commands like how 'git help' does | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 31771 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-11-21 12:48:40 PST
Created attachment 43868 [details]
Add help command
Comment on attachment 43868 [details]
Add help command
4141 class Command(object):
4242 name = None
43 show_in_main_help = False
We should just let this inherit instead of explicitly declaring False for a bunch of concrete commands.
Otherwise looks great.
(In reply to comment #2) > (From update of attachment 43868 [details]) > 4141 class Command(object): > 4242 name = None > 43 show_in_main_help = False > > We should just let this inherit instead of explicitly declaring False for a > bunch of concrete commands. > > Otherwise looks great. I did that at first and then I added the = False later, as it seemed to make the Commands more self-documenting. I take it you disagree. :) (I mentioned this in the ChangeLog.) The other option is to remove the default. Having both the default and the explicit sets doesn't seem optimal. Committed r51403: <http://trac.webkit.org/changeset/51403> |