Bug 31772 – 'bugzilla-tool help' should only show common commands like how 'git help' does

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

'bugzilla-tool help' should only show common commands like how 'git help' does

We're adding more and more commands to bugzilla-tool to support the style queues and personal workflows.  We don't need to show these to every user, as they would likely find them overwhelming.  We need to add a flag to Command to mark it as a "common" command to be shown in the primary help.

Examples of commands which we would not mark as "common":
commit-queue
style-queue
build

[Eric Seidel (no email)]

Created attachment 43868 [details]
Add help command

[Adam Barth]

Comment on attachment 43868 [details]
Add help command

4141 class Command(object):
4242     name = None
 43     show_in_main_help = False

We should just let this inherit instead of explicitly declaring False for a bunch of concrete commands.

Otherwise looks great.

[Eric Seidel (no email)]

(In reply to comment #2)
> (From update of attachment 43868 [details])
> 4141 class Command(object):
> 4242     name = None
>  43     show_in_main_help = False
> 
> We should just let this inherit instead of explicitly declaring False for a
> bunch of concrete commands.
> 
> Otherwise looks great.

I did that at first and then I added the = False later, as it seemed to make the Commands more self-documenting.  I take it you disagree. :)  (I mentioned this in the ChangeLog.)

[Adam Barth]

The other option is to remove the default.  Having both the default and the explicit sets doesn't seem optimal.

[Eric Seidel (no email)]

Committed r51403: <http://trac.webkit.org/changeset/51403>