Bug 31762 – ARIA: support aria-flowto

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

http://www.w3.org/WAI/PF/aria/complete#aria-flowto

this should be AXLinkedUIElements on the Mac

[chris fleizach]

Created attachment 43642 [details]
patch

[Oliver Hunt]

Comment on attachment 43642 [details]
patch

r=me

[chris fleizach]

Comment on attachment 43642 [details]
patch

let's try the commit queue

[WebKit Commit Bot]

Comment on attachment 43642 [details]
patch

Clearing flags on attachment: 43642

Committed r51304: <http://trac.webkit.org/changeset/51304>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Oliver Hunt]

(In reply to comment #3)
> (From update of attachment 43642 [details])
> let's try the commit queue

Chris, we like to keep the commit queue for patches from people who don't have commit privileges, rather than for commit from people who can do it themselves

[chris fleizach]

Using the commit queue is incredibly useful. I do most of my WebKit work at home, but the patches are reviewed during the day. I don't have the code with me, but I can still get it in during the day. Is there a reason you don't want me using the commit-queue?

(In reply to comment #6)
> (In reply to comment #3)
> > (From update of attachment 43642 [details] [details])
> > let's try the commit queue
> 
> Chris, we like to keep the commit queue for patches from people who don't have
> commit privileges, rather than for commit from people who can do it themselves

[Eric Seidel (no email)]

If there are concerns as to who should use the commit queue and who shouldn't those should be brought up on webkit-dev.  As far as I'm concerned anyone can use it.  Certainly Adam Barth and I use it for most of our patches despite us both being committers.

[Sam Weinig]

(In reply to comment #8)
> If there are concerns as to who should use the commit queue and who shouldn't
> those should be brought up on webkit-dev.  As far as I'm concerned anyone can
> use it.  Certainly Adam Barth and I use it for most of our patches despite us
> both being committers.

I brought this up on webkit-dev last month.  https://lists.webkit.org/pipermail/webkit-dev/2009-October/010195.html. To reiterate the points, using the bot incorrectly removes the burden of checking for failures and messes up statistic gathering.

[Adam Barth]

> I brought this up on webkit-dev last month. 
> https://lists.webkit.org/pipermail/webkit-dev/2009-October/010195.html. To
> reiterate the points, using the bot incorrectly removes the burden of checking
> for failures and messes up statistic gathering.

I don't see any consensus on that thread.  No one responded to my question of whether that had ever actually happened.

[chris fleizach]

I also like the commit-queue because it means i can stage multiple patches at the same time and let the commit-queue commit only the necessary bits, while my local copy has multiple modifications for different bugs.

(In reply to comment #10)
> > I brought this up on webkit-dev last month. 
> > https://lists.webkit.org/pipermail/webkit-dev/2009-October/010195.html. To
> > reiterate the points, using the bot incorrectly removes the burden of checking
> > for failures and messes up statistic gathering.
> 
> I don't see any consensus on that thread.  No one responded to my question of
> whether that had ever actually happened.