Summary: | REGRESSION(r51230): commit-queue made a non-sensical rejection during git svn dcommit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, zoltan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 29914 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-11-20 11:33:38 PST
We saw a similar rejection just now: https://bugs.webkit.org/show_bug.cgi?id=31689#c20 Now that I understand what's going wrong this should be simple to fix! :) the git svn dcommit call just needs to pass the include_stderr flag. Many of the calls probably need to have that enabled. In fact, I would suggest that include_stderr be enabled for all callers of run_command except for the one or two that the patch was trying to fix. Created attachment 43839 [details]
Patch
Comment on attachment 43839 [details]
Patch
svn-create-patch is actually the culprit of the stderr in diffs. :) As you can see in this diff you uploaded.
Created attachment 43861 [details]
Patch
Comment on attachment 43861 [details]
Patch
LGTM.
Comment on attachment 43861 [details]
Patch
We could also unit test this, with an scm_unittest.py test. My review still stands, but a unit test would be nice, so that we don't break this again.
You were very fast! I'd wrote this: "You're right! Now it works well. (I don't see the ? xxx dir in the patch. :) )" I will write the unit test at tomorrow morning! Should I file it here or make a new bug for it? You're welcome to do either. :) Thanks! Committed r51391: <http://trac.webkit.org/changeset/51391> I'll have time only next week for the unit-test. I opened a bug for it: #31916 |