Bug 31731

Summary: [Android] Android does not support ICU encoding x-mac-cyrillic
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED INVALID    
Severity: Normal CC: android-webkit-unforking, ap, jshin, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch 1 for Bug 31731 ap: review-

Steve Block
Reported 2009-11-20 10:42:06 PST
Android does not support ICU encoding x-mac-cyrillic. This is used in TextCodecICU::registerExtendedEncodingNames.
Attachments
Patch 1 for Bug 31731 (1.77 KB, patch)
2009-11-20 11:07 PST, Steve Block 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2009-11-20 11:07:28 PST
Created attachment 43598 [details] Patch 1 for Bug 31731
Alexey Proskuryakov
Comment 2 2009-11-20 16:05:51 PST
Comment on attachment 43598 [details] Patch 1 for Bug 31731 I don't think that this is quite right. Chromium also stripped x-mac-cyrillic from ICU, but we don't have ifdefs for this in TextCodecICU.cpp. We shouldn't be using different solutions for the same problem on different platforms. On a higher level, it's still a mystery to me why Chromium and Android go to such lengths to remove support for an encoding. See bug 21581 for some earlier discussion.
Alexey Proskuryakov
Comment 3 2009-12-02 12:14:11 PST
An example of a site that still re-encodes to Mac Cyrillic for Mac browsers: <http://magazines.russ.ru/continent/2003/117/s22.html>.
Steve Block
Comment 4 2009-12-04 11:22:05 PST
It turns out that Chromium does now support x-mac-cyrillic. I've updated Android to support it too, so the bug is redundant.
Note You need to log in before you can comment on or make changes to this bug.