Bug 31708

Summary: Change some [Reflect] attributes in HTMLInputElement to [ConvertNullToNullString, Reflect]
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch (rev.2) none

Kent Tamura
Reported 2009-11-19 22:52:38 PST
min, max, pattern and step attributes are declared as [Reflect] in WebCore/html/HTMLInputElement.idl. I'd like to change them to [ConvertNullToNullString, Reflect] because all other attribute with Reflect has ConvertNullToNullString.
Attachments
Proposed patch (4.17 KB, patch)
2009-11-19 22:55 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Proposed patch (rev.2) (10.43 KB, patch)
2009-11-19 23:28 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2009-11-19 22:55:39 PST
Created attachment 43556 [details] Proposed patch
Darin Adler
Comment 2 2009-11-19 23:08:14 PST
Comment on attachment 43556 [details] Proposed patch Changing step seems fine, but I don't see any tests for max or min.
Kent Tamura
Comment 3 2009-11-19 23:28:57 PST
Created attachment 43557 [details] Proposed patch (rev.2) Ok, I have added test for min, max and pattern attributes.
Adam Barth
Comment 4 2009-11-30 12:32:24 PST
style-queue successfully ran check-webkit-style on attachment 43557 [details] without any errors
WebKit Commit Bot
Comment 5 2009-12-01 21:17:18 PST
Comment on attachment 43557 [details] Proposed patch (rev.2) Clearing flags on attachment: 43557 Committed r51584: <http://trac.webkit.org/changeset/51584>
WebKit Commit Bot
Comment 6 2009-12-01 21:17:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.