Summary: | [chromium] Add setCaretBlinkInterval API | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joel Stanley <joel> | ||||||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | evan, fishd, levin | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joel Stanley
2009-11-19 21:03:13 PST
Created attachment 43547 [details]
patch
(I am not a reviewer) The changelog description should probably mention what port it's for. The comment in WebView.h is probably unnecessary. LGTM otherwise Comment on attachment 43547 [details] patch > +++ b/WebKit/chromium/src/WebViewImpl.cpp ... > +void WebViewImpl::setCaretBlinkInterval(double interval) { > +#if PLATFORM(LINUX) > + reinterpret_cast<RenderThemeChromiumLinux*>(theme())->setCaretBlinkInterval(interval); > +#endif > +} theme() actually returns a singleton, so mutating this singleton via a WebView instance is a bit confusing since it would cause the value to be changed for all WebView instances. since this is Linux only, perhaps you should just create a linux specific header file in public/linux that exposes a static setter for this propery. -darin Created attachment 47924 [details]
updated
Here is another try at this patch.
Note that it doesn't pass check-webkit-style due to unnecessary indentation in WebCore/rendering/RenderThemeChromiumLinux.h, which was preexisting. I left it as is to minimise noise in the patch.
Created attachment 47977 [details]
patch
Comment on attachment 47977 [details] patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > +2010-02-02 Joel Stanley <joel@jms.id.au> > + > + Reviewed by NOBODY (OOPS!). > + > + [Chromium] Make setCaretBlinkInterval static. This should include a bug link here like you did in the other changelog in this patch. I'll land this and do the fix suggested. Committed as http://trac.webkit.org/changeset/54280 |