Summary: | MessagePorts always look remotely entangled even when closed. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wilson <atwilson> | ||||||
Component: | WebCore Misc. | Assignee: | Andrew Wilson <atwilson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, jam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Andrew Wilson
2009-11-19 18:16:13 PST
Created attachment 43748 [details]
proposed patch
The old V8 GC code relied on the fact that a port could not be disentangled during GC, which is clearly incorrect. I updated/simplified this code to do the right thing now (add a reference to entangled ports at the start of GC, and remove the reference from all referenced ports at the end).
Created attachment 43749 [details]
Updated patch after removing unnecessary constant
We no longer need to keep around an extra field to store a reference to the locally entangled port, so I removed it.
Comment on attachment 43749 [details] Updated patch after removing unnecessary constant Clearing flags on attachment: 43749 Committed r51392: <http://trac.webkit.org/changeset/51392> All reviewed patches have been landed. Closing bug. |