Bug 31696

Summary: Add expected pixel result for layout test input-file-re-render
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, fishd, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed Patch
fishd: review+, commit-queue: commit-queue-
Remove tab from ChangLog none

Victor Wang
Reported 2009-11-19 17:06:54 PST
Layout test input-file-re-render.html was recently added by patch http://trac.webkit.org/changeset/50868, pixel result is not part of the patch. Chromium test shell runs pixel test by default. add pixel result so chromium could use it.
Attachments
Proposed Patch (26.86 KB, patch)
2009-11-19 17:10 PST, Victor Wang 		fishd: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Remove tab from ChangLog (26.86 KB, patch)
2009-11-19 21:45 PST, Victor Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2009-11-19 17:10:48 PST
Created attachment 43537 [details] Proposed Patch
WebKit Commit Bot
Comment 2 2009-11-19 21:38:26 PST
Comment on attachment 43537 [details] Proposed Patch Rejecting patch 43537 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: c/fast/forms/input-file-re-render-expected.png A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/LayoutTests/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/libexec/git-core//git-svn line 469
Victor Wang
Comment 3 2009-11-19 21:45:45 PST
Created attachment 43549 [details] Remove tab from ChangLog
WebKit Commit Bot
Comment 4 2009-11-20 09:53:38 PST
Comment on attachment 43549 [details] Remove tab from ChangLog Clearing flags on attachment: 43549 Committed r51241: <http://trac.webkit.org/changeset/51241>
WebKit Commit Bot
Comment 5 2009-11-20 09:53:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.