Bug 31671

Summary: Android port lacks configuration in Platform.h and config.h
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch 1 for Bug 31671 none

Description Steve Block 2009-11-19 09:53:42 PST
Android port lacks configuration in Platform.h and config.h
Comment 1 Steve Block 2009-11-19 11:43:52 PST
Created attachment 43515 [details]
Patch 1 for Bug 31671
Comment 2 Eric Seidel (no email) 2009-11-19 21:45:06 PST
Comment on attachment 43515 [details]
Patch 1 for Bug 31671

What's an inval?

 541 // This prevents unnecessary invals.

Wow, I didn't nkow this was in config.h:
 79 #define WEBCORE_NAVIGATOR_VENDOR "Google Inc."

Seems slightly lame to add.

I clearly should look at config.h again, because this all looks very strange.
Comment 3 WebKit Commit Bot 2009-11-19 22:03:24 PST
Comment on attachment 43515 [details]
Patch 1 for Bug 31671

Clearing flags on attachment: 43515

Committed r51228: <http://trac.webkit.org/changeset/51228>
Comment 4 WebKit Commit Bot 2009-11-19 22:03:29 PST
All reviewed patches have been landed.  Closing bug.