Bug 31645

Summary: CommitQueue should fetch list of patches on every cycle (and not use PatchCollection)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
example of broken logging ui
example of commit re-tries not working
Patch none

Description Eric Seidel (no email) 2009-11-18 14:00:38 PST
Created attachment 43457 [details]
example of broken logging ui

workqueue.py results in totally broken commit-queue UI

Adam warned me about some functional changes as a result of the new workqueue.py.  But it looks like one of them needs to be immediately fixed.  commit-queue needs to reload the list of bugs after every failure.  I'll attach an example of hte broken UI.
Comment 1 Eric Seidel (no email) 2009-11-18 14:17:35 PST
Created attachment 43460 [details]
example of commit re-tries not working

Sad!  Looks like commit re-tries are broken as a result of this too. :(
Comment 2 Eric Seidel (no email) 2009-11-18 14:21:29 PST
I think the problem is more PatchCollection than the WorkQueue itself.  Well, maybe both are at fault.  We should be refreshing the patch collection after every iteration (at least for the commit-queue).  I'm actually not sure commit-queue really wants to use a PatchCollection at all.
Comment 3 Eric Seidel (no email) 2009-11-18 14:46:15 PST
Created attachment 43463 [details]
Comment 4 Eric Seidel (no email) 2009-11-18 14:49:23 PST
This bug was a bit overly dramatic when I opened it. :)  The sky is not falling.  But things are definitely better after restoring the old behavior.
Comment 5 Darin Adler 2009-11-18 16:45:51 PST
Comment on attachment 43463 [details]

Comment 6 WebKit Commit Bot 2009-11-18 18:02:07 PST
Comment on attachment 43463 [details]

Clearing flags on attachment: 43463

Committed r51160: <http://trac.webkit.org/changeset/51160>
Comment 7 WebKit Commit Bot 2009-11-18 18:02:13 PST
All reviewed patches have been landed.  Closing bug.