| Summary: | CommitQueue should fetch list of patches on every cycle (and not use PatchCollection) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 43460 [details]
example of commit re-tries not working
Sad! Looks like commit re-tries are broken as a result of this too. :(
I think the problem is more PatchCollection than the WorkQueue itself. Well, maybe both are at fault. We should be refreshing the patch collection after every iteration (at least for the commit-queue). I'm actually not sure commit-queue really wants to use a PatchCollection at all. Created attachment 43463 [details]
Patch
This bug was a bit overly dramatic when I opened it. :) The sky is not falling. But things are definitely better after restoring the old behavior. Comment on attachment 43463 [details]
Patch
rs=me
Comment on attachment 43463 [details] Patch Clearing flags on attachment: 43463 Committed r51160: <http://trac.webkit.org/changeset/51160> All reviewed patches have been landed. Closing bug. |
Created attachment 43457 [details] example of broken logging ui workqueue.py results in totally broken commit-queue UI Adam warned me about some functional changes as a result of the new workqueue.py. But it looks like one of them needs to be immediately fixed. commit-queue needs to reload the list of bugs after every failure. I'll attach an example of hte broken UI.