Summary: | Need to ASSERT(isMainThread()) in ThreadShared methods. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
Component: | WebCore Misc. | Assignee: | Dmitry Titov <dimich> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, darin, eric, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Dmitry Titov
2009-11-18 12:34:28 PST
Created attachment 43471 [details]
Proposed patch.
Added ASSERT to constructor, destructor, setParent, parent, ref and deref.
Measured run-webkit-tests on debug build - the difference is not measurable. On my machine, it takes 11 min 20 sec, +/- 10 seconds from run to run, I can not see the difference.
Comment on attachment 43471 [details]
Proposed patch.
r=me
So this assertion is not hit at all anywhere in the regression tests? (In reply to comment #3) > So this assertion is not hit at all anywhere in the regression tests? No, not now. It would before rollback of r50919. |