Bug 316226
| Summary: | [Site Isolation] Remove unnecessary frameID and WebFrame changes from 314363@main | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | roberto_rodriguez2 |
| Component: | New Bugs | Assignee: | roberto_rodriguez2 |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
roberto_rodriguez2
314363@main introduced changes to fix layout test window-open-local-after-network-scheme.sub.html under site isolation. The !m_shouldReuseMainFrame removal in ProvisionalPageProxy and the coreLocalFrame() change in WebFrame::commitProvisionalFrame are not needed.
The CommitTiming::Immediately fix handles the about:blank case on its own: the second takeWindowProxyAndOpenerFrom in commitProvisionalFrame transfers the WindowProxy from remoteFrame to localFrame unconditionally, and when the frame ID is non-null it is always a different frame, so the original coreFrame() code was already correct.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/178649065>
roberto_rodriguez2
Pull request: https://github.com/WebKit/WebKit/pull/66394
EWS
Committed 314515@main (d176a27fbd87): <https://commits.webkit.org/314515@main>
Reviewed commits have been landed. Closing PR #66394 and removing active labels.