Bug 31590
| Summary: | [Qt] unify resources used in WebKit/qt/tests/ | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> |
| Component: | WebKit Qt | Assignee: | Antonio Gomes <tonikitoo> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | benjamin, hausmann |
| Priority: | P2 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 32216 | ||
Antonio Gomes
Currently many autotests load their resources from external local files. see:
$ cd WebKit/qt/tests/
$ ls qwebelement/
image.png style2.css style.css ...
$ ls qwebframe/
image.png resources style.css test1.html test2.html ...
$ ls qwebhistory/data/
page1.html page2.html page3.html page4.html page5.html page6.html
$ ls qwebpage/frametest/
frame_a.html iframe2.html iframe3.html iframe.html index.html
$ ls qwebview/data/
frame_a.html index.html
$ ls resources/
test.swf
It would be good to unify all of them into a single WebKit/qt/tests/resources/ directory and make all tests to use it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antonio Gomes
i can look at that.
Benjamin Poulain
Does it really make sense to group them?
If there is not any resource that is a copy from another test, I would keep the resource close the where they are used.
Antonio Gomes
(In reply to comment #2)
> Does it really make sense to group them?
> If there is not any resource that is a copy from another test, I would keep the
> resource close the where they are used.
in fact, idea would be get the resources currently used more organized.
i do not know if just unifying them all is the plan here, but as you said, avoiding duplication, among others ...
@simon, benjamin: do you thing there is room for improvements here ?
Benjamin Poulain
(In reply to comment #3)
> i do not know if just unifying them all is the plan here, but as you said,
> avoiding duplication, among others ...
>
> @simon, benjamin: do you thing there is room for improvements here ?
I think that make sense for the image and the swf, but I would not change the .html.
Otherwise, when someone updates the html to extend a test, that could break another test.
Antonio Gomes
> I think that make sense for the image and the swf, but I would not change the
> .html.
>
> Otherwise, when someone updates the html to extend a test, that could break
> another test.
right. so there is no much gain from doing that, i believe.