Bug 31588

Summary: CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dino
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch v2. mitz: review+

Simon Fraser (smfr)
Reported 2009-11-17 08:15:40 PST
CSSKeyframesRule::findRule() and deleteRule () only seem to work if you pass percentage values. It should also work if you pass 'from' and 'to'. The spec also needs to be clarified here.
Attachments
Patch (5.16 KB, patch)
2009-11-21 12:51 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch v2. (5.39 KB, patch)
2009-11-21 15:38 PST, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-11-21 12:51:55 PST
Created attachment 43656 [details] Patch
mitz
Comment 2 2009-11-21 12:57:34 PST
Comment on attachment 43656 [details] Patch CSSOM APIs like getPropertyValue() are case-insensitive. Shouldn’t this also be case-insensitive?
Simon Fraser (smfr)
Comment 3 2009-11-21 15:28:05 PST
Good point.
Simon Fraser (smfr)
Comment 4 2009-11-21 15:38:06 PST
Created attachment 43660 [details] Patch v2.
mitz
Comment 5 2009-11-21 15:45:59 PST
Comment on attachment 43660 [details] Patch v2. > + if (key.lower() == "from") I think the way this is typically done is using equalIgnoringCase, although I thought there was also a special function for when one of the strings is known to be all-lowercase, but I can’t find it right now. r=me either way
Simon Fraser (smfr)
Comment 6 2009-11-21 16:19:36 PST
http://trac.webkit.org/changeset/51289
Note You need to log in before you can comment on or make changes to this bug.