Bug 315582
| Summary: | Simplify DeprecatedCSSOMValue class hierarchy by using virtual functions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
Due to how it was extracted from CSSValue, DeprecatedCSSOMValue doesn't use virtual functions for its hierarchy, instead using switch statements. This is unnecessary for a rarely used type and making it use traditional virtual functions will make refactoring a bit easier.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/65696
EWS
Committed 313973@main (4029f1176cf7): <https://commits.webkit.org/313973@main>
Reviewed commits have been landed. Closing PR #65696 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/178057125>