Bug 315451
| Summary: | [GTK][WPE] Bump wkdev-sdk to a Swift-enabled version | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | WPE WebKit | Assignee: | Nikolas Zimmermann <zimmermann> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, commit-queue, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 315728 | ||
| Bug Blocks: | |||
Nikolas Zimmermann
.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nikolas Zimmermann
Pull request: https://github.com/WebKit/WebKit/pull/65559
EWS
Committed 313985@main (cb4071b9f2f0): <https://commits.webkit.org/313985@main>
Reviewed commits have been landed. Closing PR #65559 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 315728
Nikolas Zimmermann
Pull request: https://github.com/WebKit/WebKit/pull/66014
EWS
Committed 314133@main (ec528c8f3066): <https://commits.webkit.org/314133@main>
Reviewed commits have been landed. Closing PR #66014 and removing active labels.
alan
This broke my build.
OpenSource/Tools/Scripts/swift/swiftc-wrapper.sh: line 66: syntax error near unexpected token `)'
ninja: build stopped: subcommand failed.
alan
apparently this fixes it (but I have no idea if it's the correct change)
diff --git a/Tools/Scripts/swift/swiftc-wrapper.sh b/Tools/Scripts/swift/swiftc-wrapper.sh
index d6997f826792..b64fa3f977c0 100755
--- a/Tools/Scripts/swift/swiftc-wrapper.sh
+++ b/Tools/Scripts/swift/swiftc-wrapper.sh
@@ -59,6 +59,7 @@ for arg in "$@"; do
"-include") skip_next=1 ;;
"-fuse-ld="*)
args+=("-Xcc" "$arg")
+ ;;
# swiftc does not understand clang-specific include flags like
# -isystem / -iquote / -idirafter; wrap them (and their following
# path argument) as -Xcc so they reach the Clang importer instead
Nikolas Zimmermann
Sorry, will fix ASAP.
alan
thank you.