Bug 31542

Summary: [Qt] Update the plugins manual test to help test show/hide
Product: WebKit Reporter: Girish Ramakrishnan <girish>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Add button to test css display with plugins none

Girish Ramakrishnan
Reported 2009-11-16 03:55:19 PST
Helps to check if the plugin really hides/shows correctly.
Attachments
Add button to test css display with plugins (3.05 KB, patch)
2009-11-16 03:58 PST, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1 2009-11-16 03:58:54 PST
Created attachment 43289 [details] Add button to test css display with plugins
Kenneth Rohde Christiansen
Comment 2 2009-11-16 05:18:36 PST
Girish will try to change this into a real layout test.
Eric Seidel (no email)
Comment 3 2009-11-18 15:40:08 PST
Comment on attachment 43289 [details] Add button to test css display with plugins Looks sane to me.
WebKit Commit Bot
Comment 4 2009-11-18 17:00:47 PST
Comment on attachment 43289 [details] Add button to test css display with plugins Clearing flags on attachment: 43289 Committed r51157: <http://trac.webkit.org/changeset/51157>
WebKit Commit Bot
Comment 5 2009-11-18 17:00:53 PST
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 6 2009-11-20 19:20:43 PST
(In reply to comment #2) > Girish will try to change this into a real layout test. girish, i believe it will be done in another bug (?)
Girish Ramakrishnan
Comment 7 2009-11-21 02:05:07 PST
(In reply to comment #6) > (In reply to comment #2) > > Girish will try to change this into a real layout test. > > girish, i believe it will be done in another bug (?) Probably, but many of the things are actually already automated. I am not sure how I can test if a plugin does hide/show correctly and if everything is laid out correctly, other than a manual test.
Note You need to log in before you can comment on or make changes to this bug.