Bug 315325
| Summary: | [CMake] Stage WebCore.framework bundle resources on Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | CMake | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
The CMake Mac port was not copying Source/WebCore/Resources/*.{png,tiff,
icc,html,...} into WebCore.framework/Versions/A/Resources/, so the
framework bundle shipped with only Info.plist and en.lproj/. As a
result, ImageAdapter::loadPlatformResource() — which uses
[NSBundle bundleForClass:WebCoreBundleFinder] to look up missingImage.png
and similar built-in images — returned nil, and any failed image load
crashed the WebContent process via ASSERT_NOT_REACHED() in
CachedImage::brokenImage(). The Xcode build copies these via its
Resources build phase; CMake had no equivalent.
Glob Source/WebCore/Resources/* and stage with WEBKIT_COPY_FILES so
new resources are picked up automatically. CONFIGURE_DEPENDS triggers a
re-glob when the directory changes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177664337>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/65444
EWS
Committed 313697@main (1c4443e0c62b): <https://commits.webkit.org/313697@main>
Reviewed commits have been landed. Closing PR #65444 and removing active labels.