Bug 315313
| Summary: | Web Inspector: InspectorTest.completeTest() should optionally force teardown of the inspected WebPageProxy and WebPageInspectorController inside test boundaries | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/WebKit/WebKit/pull/65376 | ||
| Bug Depends on: | 314902 | ||
| Bug Blocks: | |||
Blaze Burg
Follow-up from PR #65376 (webkit.org/b/314902) review by Qianlang Chen (the-chenergy):
> This is another instance of an inspector test failing to catch leaked
> objects and making a different test run in the same test bot fail
> instead. Maybe we should file a bug to add a functionality to
> InspectorTest.completeTest() or the async test suite to optionally
> force the teardown of the inspected WebPageProxy and its
> WebPageInspectorController within the inspector test's boundary, and
> opt into that in our site isolation layout tests.
Problem: Inspector layout tests can leave WebPageProxy / WebPageInspectorController objects alive past the test boundary. Receiver registrations or other instrumentation state then leak into a subsequent unrelated test, which is the test that actually trips an assertion or fails. Diagnosing those failures requires tracing back through the test bot run history, which is expensive.
Proposal: extend InspectorTest.completeTest() (or the async test suite scaffolding) so a test can opt into forced teardown of the inspected WebPageProxy + its WebPageInspectorController at completion. Site isolation layout tests should opt in by default since they exercise the most surface area for instrumentation lifecycle bugs.
This would have caught webkit.org/b/314902 (and the prior b/314808 instance) within the offending test, rather than surfacing as a flake in unrelated SI tests like ApplePayButton.html.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177644831>