Bug 315286
| Summary: | `git webkit pr` fails if a global `format` is defined | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> |
| Component: | Tools / Tests | Assignee: | Devin Rousso <hi> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Devin Rousso
my global `.gitconfig` has `format:%C(yellow)%h%Creset %C(cyan)%cd%Creset %C(magenta)%an%Creset %s %C(yellow)%d%Creset`
this messes with the info expected by `webkitscmpy.Git.commit`
```
Traceback (most recent call last):
File ".../WebKit/Tools/Scripts/git-webkit", line 65, in <module>
sys.exit(program.main(
File ".../WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 187, in main
return parsed.main(
File ".../WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 816, in main
branch_point = cls.pull_request_branch_point(repository, args, **kwargs)
File ".../WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 315, in pull_request_branch_point
args.issue = cls.issue_from_commits(repository, source_remote, branch_point)
File ".../WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 202, in issue_from_commits
head = repository.commit(include_log=True, include_identifier=False)
File ".../WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py", line 920, in commit
raise self.Exception('Invalid commit hash in git log')
webkitscmpy.scm_base.Exception: Invalid commit hash in git log
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Devin Rousso
Pull request: https://github.com/WebKit/WebKit/pull/65411
EWS
Committed 313699@main (6552dc7d1aa7): <https://commits.webkit.org/313699@main>
Reviewed commits have been landed. Closing PR #65411 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/177672603>