Bug 31527

Summary: QWebPageClient.h needs in some cases QCursor, but it does not include it
Product: WebKit Reporter: Carol Szabo <carol>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Description Flags
Proposed Patch none

Description Carol Szabo 2009-11-15 18:58:53 PST
WebKit Style specifies that a header file should include all header files it relies on except for config.h
QWebPageClient.h does not adhere to this standard in regards to QCursor
Patch coming soon.
Comment 1 Carol Szabo 2009-11-15 19:22:21 PST
Created attachment 43261 [details]
Proposed Patch
Comment 2 WebKit Commit Bot 2009-11-17 12:45:39 PST
Comment on attachment 43261 [details]
Proposed Patch

Rejecting patch 43261 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11628 test cases.
inspector/console-dir.html -> crashed

Exiting early after 1 failures. 9322 tests run.
367.50s total testing time

9321 test cases (99%) succeeded
1 test case (<1%) crashed
5 test cases (<1%) had stderr output
Comment 3 Eric Seidel (no email) 2009-11-17 13:05:08 PST
Comment on attachment 43261 [details]
Proposed Patch

Sigh.  Bug 31461.
Comment 4 WebKit Commit Bot 2009-11-18 14:33:54 PST
Comment on attachment 43261 [details]
Proposed Patch

Clearing flags on attachment: 43261

Committed r51137: <http://trac.webkit.org/changeset/51137>
Comment 5 WebKit Commit Bot 2009-11-18 14:33:59 PST
All reviewed patches have been landed.  Closing bug.