| Summary: | [Chromium] Allow building without SVG | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Evan Martin <evan> | ||||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | jorlow, laszlo.gombos, mark | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Evan, did you intended to put this patch up for review ? It seems to me that maybe you accidentally marked it for r-. No, the patch wasn't complete so I marked it so that it explicitly shouldn't be reviewed. Created attachment 49288 [details]
patch
Needs a changelog, arg. Created attachment 49292 [details]
patch
With this patch, my Chrome debug binary is 71mb smaller. Most of the cut fat is in DerivedSources which is the slowest file to build, too. +mark for gyp comments Chrome-side bits (not needed to land this patch, just for reference). http://codereview.chromium.org/655001 Comment on attachment 49292 [details]
patch
r=me
This is probably worth a chromium-dev post. :-)
Comment on attachment 49292 [details] patch [ 'sources': [,] [...] >- # idl rule >+ # idl rules except for svg (added below) > '<@(webcore_bindings_idl_files)', > ], >+ 'conditions': [ >+ ['enable_svg!=0', { >+ 'sources': [ >+ '<@(webcore_bindings_idl_files)', >+ ], >+ }], >+ ], This says "add webcore_bindings_idl_files to sources, and if enable_svg, add them again." I doubt that's what you meant. GYP singleton processing will strip the extras so the above won't be harmful, but you should fix it. This section should be OK the way it was prior to this patch. Wow, how does this even compile!? It is supposed to reference a different variable (the svg-specific one). |
Created attachment 43257 [details] wip patch I don't use SVG in my day-to-day debugging and it's a bunch of extra code for the compiler, linker, etc. to move around. I measured it at around 14.5% of the resulting binary size of a Debug build. We should allow building without SVG.