Bug 31518

Summary:

[GTK] Support pixel tests

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

krit, mrobinson, otte, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

41779

Bug Blocks:

Attachments:

Description	Flags
Work-In-Progress of implementing pixel dumping support	none
Convert PixelDumpSupportCairo.cpp to use NL line endings	none
Pixel test support	krit: review+

Zan Dobersek

Reported 2009-11-15 10:04:52 PST

This bug oversees the implementation of pixel dumping for the Gtk port.

Attachments
Work-In-Progress of implementing pixel dumping support (20.15 KB, patch) 2009-11-15 10:12 PST, Zan Dobersek	no flags	Details Formatted Diff Diff
Convert PixelDumpSupportCairo.cpp to use NL line endings (8.71 KB, patch) 2010-07-08 08:33 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Pixel test support (11.35 KB, patch) 2010-07-08 15:06 PDT, Martin Robinson	krit: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2009-11-15 10:12:40 PST

Created attachment 43250 [details] Work-In-Progress of implementing pixel dumping support This patch is work-in-progress and has some issues: MD5 hashing should be reworked and tested to work on both Windows and Gtk port (we share this hashing part of the code with Windows port). This problem is better commented between the code. Also, MD5.h and MD5.cpp that Windows port possesses should be brought into the build rules for Gtk port. Currently, include of <openssl/md5.h>is used, but should be removed. The diffing algorithm should be checked - it was rewritten from the Qt port and seems to work, but a check wouldn't harm. The diff image creation should be looked upon - I didn't get onto any examples of what the diff image should actually look like, so I didn't finish that off completely. More comments, suggestions etc. between the lines.

Martin Robinson

Comment 2 2010-07-07 11:14:09 PDT

As I begin implementation of this patch, I'm splitting out different parts into different bugs.

Martin Robinson

Comment 3 2010-07-08 08:33:23 PDT

Created attachment 60887 [details] Convert PixelDumpSupportCairo.cpp to use NL line endings

Xan Lopez

Comment 4 2010-07-08 14:11:14 PDT

Comment on attachment 60887 [details] Convert PixelDumpSupportCairo.cpp to use NL line endings r=me

Martin Robinson

Comment 5 2010-07-08 14:23:43 PDT

Comment on attachment 60887 [details] Convert PixelDumpSupportCairo.cpp to use NL line endings Clearing flags on attachment: 60887 Committed r62839: <http://trac.webkit.org/changeset/62839>

Martin Robinson

Comment 6 2010-07-08 15:06:27 PDT

Created attachment 60968 [details] Pixel test support

WebKit Review Bot

Comment 7 2010-07-08 15:08:52 PDT

Attachment 60968 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:32: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Martin Robinson

Comment 8 2010-07-10 14:20:23 PDT

Once again, I think this may be a false positive. This file is a platform-specific specialization implementation of an already platform-specific implementation. This means it doesn't have a header associated with it of the same name. Moving the PixelDumpSupportCairo.h include under config.h did not satisfy the style bot.

Dirk Schulze

Comment 9 2010-07-12 12:02:48 PDT

Comment on attachment 60968 [details] Pixel test support r=me

Martin Robinson

Comment 10 2010-07-12 15:22:43 PDT

Committed r63130: <http://trac.webkit.org/changeset/63130>

Note You need to log in before you can comment on or make changes to this bug.