Bug 315129
| Summary: | [CMake] Restore WebKit_DerivedHeadersForSwift dependency wiring | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | CMake | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
WebKit_SwiftCxxHeader is now created via cmake_language(DEFER CALL ...)
in WEBKIT_SETUP_SWIFT_AND_GENERATE_SWIFT_CPP_INTEROP_HEADER, so the
if(TARGET ...) guard added in 313189@main no longer matched and the
add_dependencies call was silently skipped. The swift typecheck step
then raced the preferences generator and failed with
'SharedPreferencesForWebProcess.h' file not found.
Drop the guard and defer the add_dependencies call so it runs after
WebKit_SwiftCxxHeader exists.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177470839>
zak ridouh
Wrong commit identifier in the bug description. The guard was added in https://commits.webkit.org/313434@main
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/65226
EWS
Committed 313526@main (5502e61f5335): <https://commits.webkit.org/313526@main>
Reviewed commits have been landed. Closing PR #65226 and removing active labels.