Summary: | [Qt] Implement error pages handling support to DRT. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||
Component: | Tools / Tests | Assignee: | Antonio Gomes <tonikitoo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Qt | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 30573 | ||||||
Attachments: |
|
Description
Antonio Gomes
2009-11-14 15:06:03 PST
Created attachment 43231 [details] (landed in r51037) patch 0.1 patch implements error page handling support to Qt's DRT, when an unsuccessful load happends. feature is OFF by default (so same behavior as current in all DRT), but can be enabled by called 'layoutTestController.handleErrorPages();' from layout test JS sourcecode. please comments are welcome about namings here Comment on attachment 43231 [details] (landed in r51037) patch 0.1 > + QWebPage::ErrorPageExtensionReturn* errorPage = static_cast<QWebPage::ErrorPageExtensionReturn*>(output); > + > + errorPage->content = QString("data:text/html,<body/>").toUtf8(); Wouldn't it make sense to actually print the error code? (In reply to comment #2) > (From update of attachment 43231 [details]) > > > + QWebPage::ErrorPageExtensionReturn* errorPage = static_cast<QWebPage::ErrorPageExtensionReturn*>(output); > > + > > + errorPage->content = QString("data:text/html,<body/>").toUtf8(); > > Wouldn't it make sense to actually print the error code? I think we could although error codes can be platform dependent too. we can improve it later, also. thx kenneth. > <tonikitoo> 3) and file follow up bugs to these ports to implement support for > error pages in their DRT's > <tonikitoo> ap,aroben: what do you think ? > <aroben> tonikitoo: that sounds pretty good to me > (...) FYI, filed follow up bugs for win, gtk and mac's implementations of error pages support into their DRTs: * MAC -> https://bugs.webkit.org/show_bug.cgi?id=31555 * GTK -> https://bugs.webkit.org/show_bug.cgi?id=31556 * WIN -> https://bugs.webkit.org/show_bug.cgi?id=31557 |