Bug 315046
| Summary: | Drop WPTChangeExport from `webkit-patch upload` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
We want to migrate to always using git commits for exporting changes, and that is not necessarily the case with `webkit-patch upload`.
Given nowadays `webkit-patch upload` is scarcely used, it doesn't seem worthwhile migrating this to only export changes when a commit is provided — especially when the tests currently don't cover this case at all, and trying to make this change showed many problems with the current setup of the tests with regards to git.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/65131
EWS
Committed 313623@main (870d286e69dc): <https://commits.webkit.org/313623@main>
Reviewed commits have been landed. Closing PR #65131 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/177579441>