Bug 31502

Summary:

IME looks suboptimal on Chromium/Mac

Product:

WebKit

Reporter:

Nico Weber <thakis>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

hbono, ojan, schenney, suzhe

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch.	none

Nico Weber

Reported 2009-11-13 17:55:27 PST

While the glyph selection popup is active with the Kotoeri IME, the cursor is still visible. Safari hides it. It is not possible to move the cursor the the rightmost position in the current editing range, which means hiding the cursor is prettier. Also, it matches the system behavior better. However, the lines I'm changing were probably there for a reason (they're in the initial commit of the chromium tree; I'll see if I can find an older repo somewhere). Chromium/Mac seems to work with the patch. Maybe the reason these lines were introduced is no longer valid? Can someone test this on windows / linux?

Attachments
Patch. (1.71 KB, patch) 2009-11-13 17:57 PST, Nico Weber	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nico Weber

Comment 1 2009-11-13 17:57:11 PST

Created attachment 43217 [details] Patch.

Nico Weber

Comment 2 2009-11-13 18:08:56 PST

Oh, and I discovered this while writing http://codereview.chromium.org/386032 .

Evan Martin

Comment 3 2009-11-13 19:14:37 PST

changelog description isn't descriptive

Hironori Bono

Comment 4 2009-11-15 20:43:42 PST

(In reply to comment #0) > While the glyph selection popup is active with the Kotoeri IME, the cursor is > still visible. Safari hides it. It is not possible to move the cursor the the > rightmost position in the current editing range, which means hiding the cursor > is prettier. Also, it matches the system behavior better. > > However, the lines I'm changing were probably there for a reason (they're in > the initial commit of the chromium tree; I'll see if I can find an older repo > somewhere). Chromium/Mac seems to work with the patch. Maybe the reason these > lines were introduced is no longer valid? Can someone test this on windows / > linux? It seems the problem written in my comment (deleted by this change) still happens on Windows, i.e. Windows Chromium does not render characters between |targetStart| and |targetEnd| when applying this change. On the other hand, it seems this problem does not happen either on Linux or on Mac. So, is it better to figure out why this problem happens only on Windows before applying this change? Regards, Hironori Bono

Nico Weber

Comment 5 2009-11-15 21:34:29 PST

Thanks for your comment. I agree that there's no reason to rush this. Sounds like I need to get a windows system with an IME and a chromium build set up :-/ I will ping this bug when I know more.

Note You need to log in before you can comment on or make changes to this bug.