Bug 315011
| Summary: | [GTK][WPE] Skia Compositor: use SkCanvas::drawImageRect instead of SkSurface::writePixels to upload BGRA buffers to textures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bugs-noreply, commit-queue |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 315087 | ||
| Bug Blocks: | |||
Carlos Garcia Campos
When using SkSurface::writePixels the BGRA to RGBA conversion is always done by CPU before pixels are uploaded. With SkCanvas::drawImageRect is the GL platform supports BGRA, the pixels are uploaded as BGRA and then converted by the GPU before painting.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/65100
EWS
Committed 313410@main (0862297dc193): <https://commits.webkit.org/313410@main>
Reviewed commits have been landed. Closing PR #65100 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 315087
Carlos Garcia Campos
This didn't work, we will try a different approach.