Bug 315007
| Summary: | REGRESSION(313391@main): [WPE][GTK] Building with Clang-22 produces too many warnings again | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=314914 https://bugs.webkit.org/show_bug.cgi?id=314991 |
||
Adrian Perez
In 313356@main we introduced -Wno-unsafe-buffer-usage-in-format-attr-call to silence the humungous amount of compiler warnings we get for the GTK and WPE ports. Then 313391@main shuffled things around and the warnings are back... because the flag to suppress this particular warning needs to be indicated *after* -Wunsafe-buffer-usage. That patch puts -Wno-unsafe-buffer-usage-in-format-attr-call in the global list of compiler flags, but those are always added *before* target-specific compiler flags, and we end up with them being the wrong order.
I think we could have a list of unsafe-buffer-usage related flags, that always get applied per-target, and that way the per port Options{WPE,GTK}.cmake files have a chance of modifying the list before it gets attached to targets.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/65097
EWS
Committed 313465@main (94043d8f9138): <https://commits.webkit.org/313465@main>
Reviewed commits have been landed. Closing PR #65097 and removing active labels.