Bug 314938
| Summary: | [CMake] Teach run-api-tests to find CMake built binaries with --cmake | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | CMake | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Tools/Scripts/run-api-tests had no way to target a CMake build tree.
Passing --cmake exited with "no such option", and Config.build_directory()
never forwarded --cmake to webkit-build-directory anyway, so paths always
resolved to the Xcode build products.
Add --cmake to configuration_options(), and thread it through Port
into Config, and append it to the webkit-build-directory invocation.
For example, now `run-api-tests --cmake --debug` will resolve binaries
out of WebKitBuild/cmake-mac/Debug/ (the mac-debug / mac-dev-debug
preset output) instead of WebKitBuild/Debug/.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177224796>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/65034
EWS
Committed 313522@main (5c9c77898e53): <https://commits.webkit.org/313522@main>
Reviewed commits have been landed. Closing PR #65034 and removing active labels.