Bug 314910
| Summary: | [Wasm] Build JS Wrappers and JSToWasmCallees Lazily | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> |
| Component: | WebAssembly | Assignee: | Keith Miller <keith_miller> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rbuis, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Keith Miller
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/177187656>
Keith Miller
Pull request: https://github.com/WebKit/WebKit/pull/65007
EWS
Committed 313362@main (29ac32293df6): <https://commits.webkit.org/313362@main>
Reviewed commits have been landed. Closing PR #65007 and removing active labels.
Rob Buis
It looks like this causes different behavior, i.e an empty test output, on LBSE on this test:
run-webkit-tests --release --iteration=1 --additional-platform-directory=$PWD/LayoutTests/platform/mac-tahoe-wk2-lbse-text --additional-platform-directory=$PWD/LayoutTests/platform/mac-tahoe-wk2-pixel --additional-expectations=$PWD/LayoutTests/platform/mac-tahoe-wk2-lbse-text/TestExpectations --pixel-tests --internal-feature=LayerBasedSVGEngineEnabled=true --tolerance=0.01 LayoutTests/svg/animations/svg-element-attribute-changed-crash.html
[1/1] svg/custom/resource-invalidation-crash.svg failed unexpectedly (text diff)
It looks like the "await undefined;" part may have changed behaviour. Note that "normal" SVG seems unchanged (you would have seen it on bots otherwise). Any idea for a test rewrite so we can have the same behaviour as before 313362@main?