Bug 31489

Summary: DOMHTMLSelectElement is missing some implementation
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: WebKit Misc.Assignee: Jon Honeycutt <jhoneycutt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch mitz: review+, jhoneycutt: commit-queue-

Description Jon Honeycutt 2009-11-13 13:57:09 PST 
DOMHTMLSelectElement::options() and DOMHTMLSelectElement::activateItemAtIndex() are stubs.
Comment 1 Jon Honeycutt 2009-11-13 14:15:55 PST 
Created attachment 43200 [details]
patch
Comment 2 mitz 2009-11-13 15:04:34 PST 
Comment on attachment 43200 [details]
patch

> +    ASSERT(m_element && m_element->hasTagName(selectTag));

Please split this assertion into two separate assertions.

> +    ASSERT(m_element && m_element->hasTagName(selectTag));

Ditto.
Comment 3 Jon Honeycutt 2009-11-17 15:40:18 PST 
I made Dan's change.

Landed in r51092.