Bug 31485

Summary: JSValueProtect and JSValueUnprotect don't protect API wrapper values
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2009-11-13 11:57:28 PST
toJS strips out the wrapper objects made for number cells in the API, which means the protect/unprotect become no-ops. Clearly this is a Bad Thing (tm)
Attachments
Patch (3.41 KB, patch)
2009-11-13 12:00 PST, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-11-13 12:00:07 PST
Created attachment 43182 [details] Patch
Geoffrey Garen
Comment 2 2009-11-13 12:07:40 PST
Comment on attachment 43182 [details] Patch r=me
Oliver Hunt
Comment 3 2009-11-13 12:42:41 PST
Committed r50964
Note You need to log in before you can comment on or make changes to this bug.