Bug 31474

Summary: [V8] Protect SVG animated properties from destruction in bindings.
Product: WebKit Reporter: Vitaly Repeshko <vitalyr>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
dglazkov: review-
patch v2 none

Description Vitaly Repeshko 2009-11-13 08:32:16 PST
[V8] Protect SVG animated properties from destruction in bindings.
Comment 1 Vitaly Repeshko 2009-11-13 08:37:20 PST
Created attachment 43159 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2009-11-13 08:49:27 PST
Comment on attachment 43159 [details]
patch

> +        //
> +        // where PassRefPtr::~PassRefPtr() is invoked only after foo() is
> +        // called.
> +        template <typename T>
> +        static PassRefPtr<T> withSVGContext(PassRefPtr<T> object, SVGElement* context) {

Brace on new line.

> +            setSVGContext(object.get(), context);
> +            return object;
> +        }
> +        static void* withSVGContext(void* object, SVGElement* context) {

Brace on new line.

> +            setSVGContext(object, context);
> +            return object;

Use check-webkit-style :)
Comment 3 Vitaly Repeshko 2009-11-13 09:03:35 PST
Created attachment 43163 [details]
patch v2
Comment 4 Dimitri Glazkov (Google) 2009-11-13 09:06:59 PST
Comment on attachment 43163 [details]
patch v2

One day we will drive stupid void* out of V8 bindings. But it's not going to be today.
Comment 5 WebKit Commit Bot 2009-11-13 09:42:22 PST
Comment on attachment 43163 [details]
patch v2

Rejecting patch 43163 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11617 test cases.
inspector/console-dir.html -> crashed

Exiting early after 1 failures. 9312 tests run.
488.96s total testing time

9311 test cases (99%) succeeded
1 test case (<1%) crashed
5 test cases (<1%) had stderr output
Comment 6 Dimitri Glazkov (Google) 2009-11-13 11:45:52 PST
Comment on attachment 43163 [details]
patch v2

spin again.
Comment 7 WebKit Commit Bot 2009-11-13 11:56:50 PST
Comment on attachment 43163 [details]
patch v2

Clearing flags on attachment: 43163

Committed r50958: <http://trac.webkit.org/changeset/50958>
Comment 8 WebKit Commit Bot 2009-11-13 11:56:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Eric Seidel (no email) 2009-11-13 12:02:53 PST
Added the crash log to bug 30835.