Summary: | Allow custom memory allocation control for 10 classes of the platform directory in WebCore | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Zoltan Horvath
2009-11-13 07:23:20 PST
Created attachment 43155 [details]
proposed patch
Created attachment 43156 [details]
proposed patch
Comment on attachment 43156 [details] proposed patch > - class ContextMenuItem { > + class ContextMenuItem : public FastAllocBase { Should be Noncopyable instead. > - class PlatformKeyboardEvent { > + class PlatformKeyboardEvent : public FastAllocBase { I think this should be Noncopyable instead. Needs testing to be sure. review- because we'd like keep direct FastAllocBase use to a minimum and use Noncopyable whenever appropriate. (In reply to comment #3) > (From update of attachment 43156 [details]) > > - class ContextMenuItem { > > + class ContextMenuItem : public FastAllocBase { > > Should be Noncopyable instead. It can't be Noncopyable because WebCore/platform/qt/ContextMenuQt.cpp:51 m_items.append(item); copies a ContextMenuItem instance. > > - class PlatformKeyboardEvent { > > + class PlatformKeyboardEvent : public FastAllocBase { > > I think this should be Noncopyable instead. Needs testing to be sure. > > review- because we'd like keep direct FastAllocBase use to a minimum and use > Noncopyable whenever appropriate. The PlatformKeyboardEvent's problem comes from WebCore/dom/KeyboardEvent.cpp:63 it would use its copy constructor. Btw, I analyzed all classes in the patch, and if a class is inherited from FastAllocBase than it won't compile with Noncopyable some reason. Comment on attachment 43156 [details]
proposed patch
I mark it to r? again.
Landed in 51149. http://trac.webkit.org/changeset/51149 |