Bug 314711
| Summary: | [GTK][WPE] Skia Compositor: move painting of platform buffers to SkiaCompositingLayer | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
All CoordinatedPlatformLayerBuffer implementations now paint the same way by calling SkCanvas::drawImageRect(), the only difference is how the SkImage is created in each case. So, we can call SkCanvas::drawImageRect() in SkiaCompositingLayer and the platform buffers only need to provide the image to paint. The only exception is CoordinatedPlatformLayerBufferHolePunch that we can handle differently by setting the hole puch rect and painting with transparent color from SkiaCompositingLayer too. This will allow us to implement batched painting.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/64825
EWS
Committed 313149@main (a2209c6caff2): <https://commits.webkit.org/313149@main>
Reviewed commits have been landed. Closing PR #64825 and removing active labels.