Bug 314663
| Summary: | [import-w3c-tests] Avoid needlessly rewriting tests on import | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=207731 https://bugs.webkit.org/show_bug.cgi?id=268218 |
||
Sam Sneddon [:gsnedders]
While in https://github.com/WebKit/WebKit/pull/64614 for bug 207731 annevk added a `import-no-rewrite` value to `import-expectations.json`, this only avoids the issue for anything specifically marked.
Leaving bug 268218 for the "anything gets rewritten case", we can still improve on this by simply _not_ rewriting the majority of files — and instead only using the serialised output if we actually modified anything.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176914827>
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/64780
EWS
Committed 313428@main (5a55efcfb4ea): <https://commits.webkit.org/313428@main>
Reviewed commits have been landed. Closing PR #64780 and removing active labels.