Bug 314636

Summary: MacroAssemblerRISCV64 uses undefined EnableIfInteger in immediate helpers
Product: WebKit Reporter: h.dwwwwww
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   

h.dwwwwww
Reported 2026-05-12 05:29:21 PDT
MacroAssemblerRISCV64::Imm constrains the integer overloads for I(), S(), and B() with EnableIfInteger<T>, but EnableIfInteger is not defined in WebKit. These are the only references to that name. As a result, RISCV64 builds that parse MacroAssemblerRISCV64.h fail when ENABLE(ASSEMBLER) is enabled. The existing codebase already uses C++20 std::integral for this kind of constraint, so these overloads should use template<std::integral T> instead.
Attachments
Add attachment proposed patch, testcase, etc.
EWS
Comment 1 2026-05-12 23:46:19 PDT
Committed 313137@main (6b720e4ce33c): <https://commits.webkit.org/313137@main> Reviewed commits have been landed. Closing PR #64756 and removing active labels.
Radar WebKit Bug Importer
Comment 2 2026-05-12 23:47:12 PDT
<rdar://problem/176952978>
Note You need to log in before you can comment on or make changes to this bug.