Summary: | Update the description of fast/overflow/004.html to match the results | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kinuko Yasuda <kinuko> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Minor | CC: | eric, hyatt, kinuko, mitz | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Kinuko Yasuda
2009-11-12 21:51:58 PST
Created attachment 43142 [details]
Update the description of fast/overflow/004.html
Comment on attachment 43142 [details]
Update the description of fast/overflow/004.html
I think Hyatt should review this one since he wrote the original test. Or maybe Mitz can clarify.
(In reply to comment #1) > Created an attachment (id=43142) [details] > Update the description of fast/overflow/004.html Oops, I haven't attached updated expected results to this patch - I'll update it later. Created attachment 43265 [details]
Update the description and expected results for fast/overflow/004.html
+hyatt Could you take a look at this? Thanks, Adding mitz also per darin's suggestion. Comment on attachment 43265 [details]
Update the description and expected results for fast/overflow/004.html
I think it’s better to make the blocks fit on the same line again. One way to do this is to add “-webkit-box-sizing: border-box;” to their style attributes.
Created attachment 43490 [details]
Update fast/overflow/004.html to match the test description and expected results.
Comment on attachment 43490 [details]
Update fast/overflow/004.html to match the test description and expected results.
Thanks!
r=me
Thanks for reviewing, would you mind committing this when you have time? (In reply to comment #10) > Thanks for reviewing, would you mind committing this when you have time? Done. <http://trac.webkit.org/projects/webkit/changeset/51178> Thank you mitz! Yasuda-san: you can also just set commit-queue=? and someone will set commit-queue=+ and the commit bot will automatically land the patch instead of needing human intervention. The process is described here: http://webkit.org/coding/contributing.html Totally up to you. (In reply to comment #12) > Thank you mitz! > > Yasuda-san: you can also just set commit-queue=? and someone will set > commit-queue=+ and the commit bot will automatically land the patch instead of > needing human intervention. The process is described here: > http://webkit.org/coding/contributing.html Totally up to you. Mitz, thank you very much for committing. Also thank you for the pointer Eric. I'll use the commit-queue feature whenever it looks more appropriate / better for future patches. |