Bug 314500
| Summary: | Remove dead WKIconDatabase C API, WebIconDatabase, and APIIconDatabaseClient | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | New Bugs | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Every WKIconDatabase (and WKIconDatabaseCG) function is a no-op or
returns nullptr. The backing WebIconDatabase class has an empty body
and is never constructed. APIIconDatabaseClient has no subclasses.
WKContextGetIconDatabase and WKContextSetIconDatabasePath are no-ops;
WebKitTestRunner was their only caller. Delete it all.
The WebKitLegacy WebIconDatabase in Source/WebKitLegacy/mac/Misc/ and
the GTK/WPE WebKitFaviconDatabase glib API are unrelated and untouched.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176714451>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/64629
EWS
Committed 313751@main (0fc1e487ba52): <https://commits.webkit.org/313751@main>
Reviewed commits have been landed. Closing PR #64629 and removing active labels.