Bug 314499
| Summary: | Remove dead WKUserMediaPermissionCheck C API | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | New Bugs | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
The WKPageUIClient `checkUserMediaPermissionForOrigin` slot was retired
to `void* unused6` previously, which already cut off the only path by
which an external caller could receive a WKUserMediaPermissionCheckRef.
The C API wrapper (WKUserMediaPermissionCheckGetTypeID,
WKUserMediaPermissionCheckSetUserMediaAccessInfo) has no remaining
callers. Delete it, along with the opaque WKUserMediaPermissionCheckRef
typedef, the WK_ADD_API_MAPPING, the orphan WKCheckUserMediaPermissionCallback
typedef, stale includes in WKPage.cpp and the test tools, and the
build-system plumbing (Sources.txt, Headers.cmake, modulemaps,
WebKit.xcodeproj).
The backing UserMediaPermissionCheckProxy class is kept as-is: the
glib build still references it even though its construction path is
also unreachable. Dropping it is a larger GTK/WPE public-API change
and out of scope here.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176713900>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/64628
EWS
Committed 313756@main (db8991a09bba): <https://commits.webkit.org/313756@main>
Reviewed commits have been landed. Closing PR #64628 and removing active labels.