Bug 314494
| Summary: | Retire decidePolicyForSpeechRecognitionPermissionRequest WKPageUIClient callback slot | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | New Bugs | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Following 297219@main, the WKSpeechRecognitionPermissionCallback C API has no
callers and no bridge code inside WebKit reads the
decidePolicyForSpeechRecognitionPermissionRequest field from WKPageUIClientV15
through V19. Rename the field to `void* unused8` so the struct layout, and
thus the binary ABI for clients still compiled against these versions,
is preserved, and drop the now-orphan
WKPageDecidePolicyForSpeechRecognitionPermissionRequestCallback typedef.
This intentionally breaks source compatibility for any holdout filling the
field by name, documenting that the slot is retired, and clears the way for
a follow-up that deletes the remaining dead code.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176709259>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/64624
EWS
Committed 313459@main (48fd62d2c1b6): <https://commits.webkit.org/313459@main>
Reviewed commits have been landed. Closing PR #64624 and removing active labels.