Bug 31449

Summary:

Rename fileName parameters to vfsFileName in all DB-related methods

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

New Bugs

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, michaeln

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	dglazkov: review+, dumi: commit-queue-

Dumitru Daniliuc

Reported 2009-11-12 18:40:56 PST

Rename fileName parameters to vfsFileName in all DB-related methods, since those parameters are no longer real files names, but rather some VFS string tokens.

Attachments
patch (5.87 KB, patch) 2009-11-12 18:57 PST, Dumitru Daniliuc	dglazkov: review+ dumi: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2009-11-12 18:57:00 PST

Created attachment 43125 [details] patch

Michael Nordman

Comment 2 2009-11-12 19:23:39 PST

fwiw... lgtm

Dimitri Glazkov (Google)

Comment 3 2009-11-12 21:08:10 PST

Comment on attachment 43125 [details] patch ok.

Eric Seidel (no email)

Comment 4 2009-12-28 23:04:35 PST

Did this land? It's been approved for over a month and a half?

Eric Seidel (no email)

Comment 5 2009-12-28 23:10:12 PST

Looks like it did. r50928 Note "bugzilla-tool land-*" or "bugzilla-tool mark-fixed" will handle closing bugs and adding the landing revision for you if you wish for script-based assistance. :)

Note You need to log in before you can comment on or make changes to this bug.