Bug 314441
| Summary: | [JSC] Test microbenchmarks.yaml/microbenchmarks/intl-number-format-unit-to-parts.js.default fails on WPE and GTK but not on JSCOnly Linux | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WPE WebKit | Assignee: | Angelos Oikonomopoulos <angelos> |
| Status: | NEW | ||
| Severity: | Normal | CC: | angelos, bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
This JSC test is failing on WPE and GTK:
** The following JSC stress test failures have been introduced:
microbenchmarks.yaml/microbenchmarks/intl-number-format-unit-to-parts.js.default
WPE: https://build.webkit.org/#/builders/44/builds/104130
GTK: https://build.webkit.org/#/builders/58/builds/97145
However it is passing on JSCOnly Linux: https://build.webkit.org/#/builders/24/builds/65211
I suspect it has to be with the libICU version or something like that as the test is testing NumberFormat with international unit styles.
I'm not sure how we can garden this, can we skip the test for gtk and wpe with a comment pointing to this bug?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
I mean, not skipping it just for $memoryLimited because it is passing on JSCOnly Linux
I don't see how to skip it for platform wpe or platform gtk
Angelos Oikonomopoulos
Pull request: https://github.com/WebKit/WebKit/pull/64669
Angelos Oikonomopoulos
We can skip this test on WPE/GTK I think (see PR above), but there are more Intl-related failures in the test262 tests, which AFAIK cannot be skipped depending on the platform. Is upgrading the libicu version in the bot environments an option?
EWS
Test gardening commit 313001@main (4218e36e71ee): <https://commits.webkit.org/313001@main>
Reviewed commits have been landed. Closing PR #64669 and removing active labels.
Carlos Alberto Lopez Perez
(In reply to Angelos Oikonomopoulos from comment #3)
> We can skip this test on WPE/GTK I think (see PR above), but there are more
> Intl-related failures in the test262 tests, which AFAIK cannot be skipped
> depending on the platform. Is upgrading the libicu version in the bot
> environments an option?
We are already running the last one on GTK and WPE. See: https://github.com/Igalia/webkit-container-sdk/pull/219