Bug 314387
| Summary: | Add GlyphPageCacheEntry destructor | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
adrian_taylor
The GlyphPageCacheEntry type contains a std::unique_ptr<MixedFontGlyphPage>, where MixedFontGlyphPage is forward-declared. Swift attempts to generate an implicit destructor, causing an error. This is related to the Swift issue rdar://152495753 where it attempts sometimes to generate more special members than C++ would, but in this case, the solution is to explicitly define a destructor. This change is necessary for us to be able to annotate WebKit reference counted base classes with SWIFT_SHARED_REFERENCE.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176543249>
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/64539
EWS
Committed 312903@main (158626c98e75): <https://commits.webkit.org/312903@main>
Reviewed commits have been landed. Closing PR #64539 and removing active labels.