Bug 314350
| Summary: | Fix a bug that run-benchmark may hang on exception while executed via SSH. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | dewei_zhu |
| Component: | Tools / Tests | Assignee: | dewei_zhu |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
dewei_zhu
When run-benchmark launches Safari directly via its binary path, Safari inherits the SSH session's pipe file descriptors. If the benchmark fails, Safari is intentionally left running for diagnosis, but its inherited FDs prevent the SSH session from closing — causing the caller to hang until an external timeout kills it. The fix redirects Safari's stdin/stdout/stderr to DEVNULL since they are unused.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
dewei_zhu
<rdar://problem/176494536>
dewei_zhu
Pull request: https://github.com/WebKit/WebKit/pull/64500
EWS
Committed 312838@main (ab0f27c1a2ad): <https://commits.webkit.org/312838@main>
Reviewed commits have been landed. Closing PR #64500 and removing active labels.