Bug 314128
| Summary: | Rename SetSubframesSuspended to SetIsSuspendedWithFrameItem | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <basuke> |
| Component: | New Bugs | Assignee: | Basuke Suzuki <basuke> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Basuke Suzuki
Rename the IPC message Messages::WebPage::SetSubframesSuspended(bool, BackForwardFrameItemIdentifier) and the corresponding WebPage::setSubframesSuspended() method to SetIsSuspendedWithFrameItem / setIsSuspendedWithFrameItem respectively.
The new name better reflects the message's purpose: it handles the per-frame-item form of suspension in both suspend and (future) resume directions, in contrast to the existing SetIsSuspended(bool) message which operates on the whole page without a frame item. Also rename the parameter 'identifier' to 'frameItemID' for clarity.
This is a pure rename: no signature change, no semantic change, callers updated accordingly. Prep patch for rdar://173743733 (multi-process BFCache restoration under Site Isolation).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Basuke Suzuki
<rdar://problem/176304986>
Basuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/64307
EWS
Committed 312695@main (d0c84d38faa8): <https://commits.webkit.org/312695@main>
Reviewed commits have been landed. Closing PR #64307 and removing active labels.