Bug 314072
| Summary: | Guard Apple-specific WTF headers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
adrian_taylor
Swift/C++ interop requires a modulemap to be provided describing the layout of WTF headers. Ideally, we want to use the same modulemap for all WebKit platforms. Some of the headers listed in that modulemap are for Apple-only features. Until now, those headers were never interpreted on non-Apple platforms, but the modulemap causes Swift's embedded clang to try to build them. Solve that problem by adding platform header guards. An alternative is to add various directives in the modulemap but I understand header guards are considered best practice.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176259431>
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/64259
EWS
Committed 312898@main (4a7474b8b00a): <https://commits.webkit.org/312898@main>
Reviewed commits have been landed. Closing PR #64259 and removing active labels.